Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rector] Apply Rector: RemoveUnusedPrivatePropertyRector #4671

Merged
merged 2 commits into from
May 11, 2021
Merged

[Rector] Apply Rector: RemoveUnusedPrivatePropertyRector #4671

merged 2 commits into from
May 11, 2021

Conversation

samsonasik
Copy link
Member

Remove unused private properties with RemoveUnusedPrivatePropertyRector rector rule.

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

samsonasik commented May 11, 2021 •
edited
Loading

Temporary add symplify/composer-json-manipulator to require-dev due error in https://github.com/codeigniter4/CodeIgniter4/runs/2556009947#step:10:5 :

Run vendor/bin/rector process --dry-run --no-progress-bar

Error: ] Class                                                                  
         "Symplify\ComposerJsonManipulator\Bundle\ComposerJsonManipulatorBundle"
         not found

ref rectorphp/rector#6405 .

@samsonasik samsonasik merged commit 968ba63 into codeigniter4:develop May 11, 2021
@samsonasik samsonasik deleted the apply-rctor-remove-unused-private-property branch May 11, 2021 13:36
This was referenced May 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @paulbalandan